v5.0.0-alpha.24 #24614

eps1lon · 2021-01-25T15:00:26Z

Rendered changelog
Rendered release workflow instructions

Starting with this release, changelogs should be based on yarn release:changelog. For tagging, please use yarn release:tag. If you've done releases before, please check out the new instructions.

For all:

decide on highlights
sort contributors (would've expected appearance in changelog but that doesn't seem to be the case)
Sorted by alphanumeric asc and moved to the end

For reviewer:

changelog grouping
changelog script usage
updated release script

For me:

generate changelog in dev CI
resolve TODO items
update package versions
missing explicit dependency

mui-pr-bot · 2021-01-25T15:03:10Z

Details of bundle changes

Generated by 🚫 dangerJS against 4d48ff1

CHANGELOG.md

eps1lon · 2021-01-25T15:13:55Z

One thing we need to clarify better: How to tag.

alpha.23 was associated with a commit that is not part of this remote (af6e722).

~~[ ] I'm investigating if we can rewrite this without breaking every working tree.~~ Let's not risk it. We can guard against this in the future.

I'll probably wrap this in a script that checks if the commit is part of the correct remote.

scripts/generateChangelog.js

- docs before core - move test into core

eps1lon · 2021-01-25T16:35:19Z

scripts/README.md

-git commit -am "v5.0.0-alpha.18"
-git tag v5.0.0-alpha.18
-```
+1. `yarn relase:version`


The current behavior seems broken to me. It prompts to update every single package. Might be due to lightweight tag usage. We'll see next time if that is the case.

If lerna expects to not bump any packages I would expect an explicit option for that. Right now I can only trick it by entering the same version but that's tedious.

Lerna is configured to treat the version of the packages individually. @material-ui/types needed a different one.

In this mode and from what I could gather, Lerna needs one tag per managed version in order to only bump the correct packages in the next release. This was flooding the "Tags" tab view on GitHub. The current situation is the result of a tradeoff: bump everything (cons) in exchange for packages with multiple versions and a single tag (pros).

I'm not talking about tagging but updating version in the package.json. I don't understand why lerna thinks e.g. @material-ui/envinfo was changed.

I suspect it's either caused by lightweight tags or the last tag pointing to a commit that doesn't exist on the mui-org/material-ui remote. Hopefully it's not just bad DX.

mnajdova · 2021-01-25T16:55:00Z

One thing we need to clarify better: How to tag.

alpha.23 was associated with a commit that is not part of this remote (af6e722).

I'll probably wrap this in a script that checks if the commit is part of the correct remote.

Should we create these PRs on upstream then (mui-org)?

eps1lon · 2021-01-25T17:14:51Z

Should we create these PRs on upstream then (mui-org)?

This should be fixed in the new workflow. You won't run git tag on branches anymore. Just need to update the instructions to push it to mui-org/material-ui not the default remote. I don't know which commit you tagged. It doesn't seem to be the one you pushed to mui-org/material-ui

CHANGELOG.md

Co-authored-by: Olivier Tassinari <[email protected]>

eps1lon · 2021-01-25T18:02:48Z

Will merge the latest state of next tomorrow after lunch (1400 CET), update the changelog, merge PR and release.

eps1lon · 2021-01-26T13:34:02Z

Update: Items are now numbered by their date ascending. This ensures that the numbers stay the same over time. This makes it easier to review changelog changes over time (e.g. when new items are added).

oliviertassinari · 2021-01-26T14:24:00Z

Update: Items are now numbered by their date ascending. This ensures that the numbers stay the same over time. This makes it easier to review changelog changes over time (e.g. when new items are added).

@eps1lon Why optimize for when each change was merged? I mean what problem does it solve for developers? I was under the assumption that all the changes are released at the same time from a developer's perspective.

So far, items have been ordered alphabetically because it makes it easier, for developers, to review changes specific to a component (grouping + predictable order). Developers don't use all the components, they might only care about a subset, e.g. Accordion.

eps1lon · 2021-01-26T14:31:39Z

Why optimize for when each change was merged?

Release are ordered in time so we might as well keep the order inside a release

So far, items have been ordered alphabetically because it makes it easier, for developers, to review changes specific to a component, e.g. Accordion.

They were never ordered alphabetically though.

it makes it easier, for developers, to review changes specific to a component, e.g. Accordion.

You can still do that with searching. Assuming that these are grouped is somewhat dangerous because we never explained how each components affects each other. If they assume every change affecting Accordion is grouped under [Accordion] then they ignore changes to e.g. ButtonBase. And I'm not even going into the whole "what is grouped under [Accordion]?" topic. That is currently even more confusing. Seems to me that we just removed a footgun.

Please review more thoroughly in the future. I requested the review, even pointed to the items, yet you approved. If you don't review a PR, please don't approve it. That gives a false sense of security.

eps1lon · 2021-01-26T14:35:21Z

And please stop doing screenshots, thanks. Either link to the text or copy it so that system defaults of text can be applied.

oliviertassinari · 2021-01-26T14:43:12Z

You can still do that with searching

True, it's fair. My intent was to explain why it was sorted alphabetically so far, and to get a sense of why we were changing it for developers. The first motivation shared seemed to be maintainers-focused, which could/should be secondary. While I don't understand the motivation/problem we solve, no objections to giving this a try.

Thanks for sharing the update with a dedicated component, I didn't notice the change in the first passe. I think that the image was important to contextualize the use case here, to get a feeling of the end-to-end DX (from the update developers received by email when they subscribe).

What do you mean by they were never ordered alphabetically? The usage of .sort() was meant to achieve this outcome. Do you mean that it should have used toLocaleCompare?

Well done with the release 🙏

Release v5.0.0-alpha.24

85513d3

eps1lon added the on hold There is a blocker, we need to wait label Jan 25, 2021

eps1lon requested review from oliviertassinari and mnajdova January 25, 2021 15:00

oliviertassinari reviewed Jan 25, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

mnajdova reviewed Jan 25, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mnajdova reviewed Jan 25, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mnajdova reviewed Jan 25, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mnajdova reviewed Jan 25, 2021

View reviewed changes

scripts/generateChangelog.js Outdated Show resolved Hide resolved

eps1lon added 7 commits January 25, 2021 16:28

Untangle sort indirection

8874739

Default to latest tag version

76c3d0b

Create changelog in CI

9ccb911

put contributor handles at the end of the changelog

f1e9e93

Misc re-ordering

5730cee

- docs before core - move test into core

Remove [website] commits

2aaf1d1

yarn lerna version

02e35d5

eps1lon commented Jan 25, 2021

View reviewed changes

eps1lon added 5 commits January 25, 2021 17:37

Insert number of components migrated to emotion

98760d6

List PRs part of API docs effort

554b2a9

cant detect any larger highlights

d000668

fetch all tags in dev CI

6c3ee6c

Explicit dependency on octokit/rest

3fcb3f5

github-actions bot mentioned this pull request Jan 25, 2021

Update snapshots for pr/24614 eps1lon/mui-scripts-incubator#1753

Closed

oliviertassinari reviewed Jan 25, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

eps1lon and others added 2 commits January 25, 2021 18:56

Add script for tagging

4070002

Apply suggestions from code review

751eb26

Co-authored-by: Olivier Tassinari <[email protected]>

oliviertassinari approved these changes Jan 25, 2021

View reviewed changes

oliviertassinari and others added 6 commits January 25, 2021 19:20

yarn prettier

72672e0

Remove c&p artifacts

19c0a25

describe release:tag

6eaae08

Remove mention of scripts/generateChangelog

49c5b2c

Merge branch 'next' into scripts/changelog

e0e9596

make sure workflows dont break on merge commits

4d48ff1

vercel bot deployed to Preview January 26, 2021 13:33 View deployment

eps1lon changed the title ~~DO NOT MERGE Release v5.0.0-alpha.24~~ Release v5.0.0-alpha.24 Jan 26, 2021

eps1lon removed the on hold There is a blocker, we need to wait label Jan 26, 2021

eps1lon merged commit 15108a5 into mui:next Jan 26, 2021

eps1lon deleted the scripts/changelog branch January 26, 2021 14:03

oliviertassinari added the release We are shipping :D label Dec 21, 2021

oliviertassinari changed the title ~~Release v5.0.0-alpha.24~~ v5.0.0-alpha.24 Dec 21, 2021

michaldudak mentioned this pull request Dec 21, 2021

v5.2.5 #30288

Merged

oliviertassinari mentioned this pull request Oct 9, 2024

[core] Remove <-- from changelog #44052

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5.0.0-alpha.24 #24614

v5.0.0-alpha.24 #24614

eps1lon commented Jan 25, 2021 •

edited

Loading

mui-pr-bot commented Jan 25, 2021 •

edited

Loading

eps1lon commented Jan 25, 2021 •

edited

Loading

eps1lon Jan 25, 2021

oliviertassinari Jan 25, 2021 •

edited

Loading

eps1lon Jan 26, 2021

mnajdova commented Jan 25, 2021

eps1lon commented Jan 25, 2021

eps1lon commented Jan 25, 2021

eps1lon commented Jan 26, 2021

oliviertassinari commented Jan 26, 2021 •

edited

Loading

eps1lon commented Jan 26, 2021

eps1lon commented Jan 26, 2021

oliviertassinari commented Jan 26, 2021 •

edited

Loading

v5.0.0-alpha.24 #24614

v5.0.0-alpha.24 #24614

Conversation

eps1lon commented Jan 25, 2021 • edited Loading

mui-pr-bot commented Jan 25, 2021 • edited Loading

eps1lon commented Jan 25, 2021 • edited Loading

eps1lon Jan 25, 2021

Choose a reason for hiding this comment

oliviertassinari Jan 25, 2021 • edited Loading

Choose a reason for hiding this comment

eps1lon Jan 26, 2021

Choose a reason for hiding this comment

mnajdova commented Jan 25, 2021

eps1lon commented Jan 25, 2021

eps1lon commented Jan 25, 2021

eps1lon commented Jan 26, 2021

oliviertassinari commented Jan 26, 2021 • edited Loading

eps1lon commented Jan 26, 2021

eps1lon commented Jan 26, 2021

oliviertassinari commented Jan 26, 2021 • edited Loading

eps1lon commented Jan 25, 2021 •

edited

Loading

mui-pr-bot commented Jan 25, 2021 •

edited

Loading

eps1lon commented Jan 25, 2021 •

edited

Loading

oliviertassinari Jan 25, 2021 •

edited

Loading

oliviertassinari commented Jan 26, 2021 •

edited

Loading

oliviertassinari commented Jan 26, 2021 •

edited

Loading